This repository has been archived by the owner on Jul 18, 2024. It is now read-only.
YSHOP2-329: [Features collections] Padding bottom does not seems to work #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adildev101
added
the
💻 Ready for review
bj-anas
reviewed
Apr 12, 2023
bj-anas
reviewed
Apr 12, 2023
|
we already have it also on this version just a different on the naming, on cod theme v3 i name it space top or bottom and hire we have margin top or bottom |
|
okay so why we will add padding over the margin ? |
using padding or margin it's doesn't matter I said please try to unify the settings for all COD themes on what ever you like |
|
@bj-anas we don't rely on other themes settings hire on COD 1 we use padding or margin for the space naming. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
YSHOP2-329
QA Steps
pnpm ipnpm devNote
Leave empty when you have nothing to say